[a11y] Fix: Use spans instead of headings on dataviews table view page title #56956
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +24 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 93b6bd2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7213719194
|
|
Removing the h3 is great, but there is something wrong here. This is what I see:
|
jorgefilipecosta
force-pushed
the
fix/use-spans-instead-of-headings-on-dataview-table-view-page-title
branch
from
950af13 to
93b6bd2
Compare
|
Hi @oandregal, thank you for the review, the visual issue was fixed. |
oandregal
approved these changes
Dec 15, 2023
oandregal
deleted the
fix/use-spans-instead-of-headings-on-dataview-table-view-page-title
branch
bph
added
[Type] Experimental
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue referred by @afercia where the dataviews table view uses a h3 heading in the titles cells.
This PR fixes the issue for the pages view
/wp-admin/site-editor.php?path=%2Fpages.Testing
Verify the pages UI looks the same as in the trunk.
Verify the page's title is now a span and not a heading.